Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geth sharding entrypoint and contract deployment #3

Merged
merged 26 commits into from
Jan 22, 2018
Merged

geth sharding entrypoint and contract deployment #3

merged 26 commits into from
Jan 22, 2018

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Jan 15, 2018 •
edited
Loading

Some feature / TODO items to be completed in another pull request.

Feature status:

  • Create geth entrypoint geth shard
  • Accept --datadir flag
  • Accept geth shard [path/to/geth.ipc] (same as geth attach)
  • Check for existing validator management contract (VMC)
  • Deploy static contract bytecode when VMC is not present (i.e. on testnets)
  • Verify existing VMC is expected bytecode Do this in another PR.

TODOs before submit:

  • Load password from file (currently hardcoded as "password")
  • Comment on lookahead periods
  • Code comments on all public methods
  • Code comments on private methods (as needed)
  • Handle keystore panic Do this in another PR.
  • Add brief sharding command description
  • Fix/add basic tests

@prestonvanloon prestonvanloon self-assigned this Jan 15, 2018
fjl and others added 16 commits January 16, 2018 15:42
@fjl
cmd/ethkey: fix formatting, review nits (ethereum#15807)
f08cd94 
This commit:

- Adds a --msgfile option to read the message to sign from a file
  instead of command line argument.
- Adds a unit test for signing subcommands.
- Removes some weird whitespace in the code.
@shapeshed
core/vm: Fix comment typo
370dca4
@karalabe
Merge pull request ethereum#15902 from shapeshed/patch-2
02aeb3d 
core/vm: Fix comment typo
@prestonvanloon
Properly support datadir
a403b91
@prestonvanloon
using password file, some method comments, working getCode for contract
6f385bd
@prestonvanloon
update abi and bytecode
80e3a1b
@prestonvanloon
use common.hex2bytes
f6a29d3
@prestonvanloon
update error messages, update VMC addr with newly created, check byte…
d0b5374 
…code (not working yet)
@prestonvanloon
Working on tests for sharding client
502c856
@prestonvanloon
Use network id from command line
db78e7a
@prestonvanloon
Merge branch 'master' of github.com:prysmaticlabs/geth-sharding into …
8780b71 
…sharding
@prestonvanloon
Add sharding alias
1e788c4
@prestonvanloon
cleanup / move methods
bf6624f
@prestonvanloon
fix deps and allow passing the datadir as the first arg like geth attach
256b317
@prestonvanloon
Add a basic command description
7e053de
@prestonvanloon
finish lookahead period comment
62ea0db
@prestonvanloon prestonvanloon changed the title WIP: geth sharding entrypoint and contract deployment geth sharding entrypoint and contract deployment Jan 21, 2018
@Magicking
Copy link
Contributor

lgtm to geth started but I'm not fan of the vmc.go since there is already
https://godoc.org/github.com/ethereum/go-ethereum/accounts/abi/bind#NewBoundContract
and https://godoc.org/github.com/ethereum/go-ethereum/accounts/abi/bind#DeployContract to handle that.

@rauljordan
Copy link
Contributor

Agree with @Magicking. The code does work though and it is a good entry point so far into our implementation. I suggest we do merge and then refactor using these internal functions to reduce the amt of code. I really want these changes into master for my development. I did get some issues running tests: the /geth.ipc endpoint tmp file creation is an invalid argument to the node config. Also, I would like to see a bit more comments on the tests if possible as they are the first files I look at when trying out a new branch.

I would like to definitely get this merged asap, however.

rauljordan
rauljordan approved these changes Jan 22, 2018
View reviewed changes
Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything good for a first run. The code works and it's just a matter of refactoring vmc.go in the future to incorporate the internal ABI helpers.

@rauljordan rauljordan merged commit 6bd2d29 into prysmaticlabs:master Jan 22, 2018
@rauljordan rauljordan mentioned this pull request Mar 25, 2018
Merged
prestonvanloon pushed a commit that referenced this pull request Jul 22, 2018
@rauljordan
Merge pull request #3 from prestonvanloon/sharding
b3969a9 
geth sharding entrypoint and contract deployment
prestonvanloon pushed a commit that referenced this pull request Jul 22, 2018
@rauljordan
Merge pull request #3 from prestonvanloon/sharding
4b8e449 
geth sharding entrypoint and contract deployment

Former-commit-id: b3969a9
prestonvanloon pushed a commit that referenced this pull request Jul 22, 2018
@rauljordan
Merge pull request #3 from prestonvanloon/sharding
71860e6 
geth sharding entrypoint and contract deployment

Former-commit-id: ba96e81a08e862ab78d7aaf96eba5709875d9704 [formerly b3969a9]
Former-commit-id: 4b8e449
@terencechain terencechain mentioned this pull request Oct 10, 2018
Merged
@dv8silencer dv8silencer mentioned this pull request Jun 23, 2020
Merged
@bvukich bvukich mentioned this pull request Aug 4, 2020
Closed
potuz added a commit that referenced this pull request Apr 5, 2022
@potuz
terence's review #3
367778b
prylabs-bulldozer bot pushed a commit that referenced this pull request Apr 6, 2022
@potuz @terencechain
Remove synced tips and use last valid hash (#10439)
83a8327 
* Remove synced tips

use last valid hash in removing invalid nodes.

* add test

* Remove unused code

* More unused parameters

* Fix proposer boost

* terence's review #1

* Fix conflicts

* terence's review 2

* rename argument

* terence's review #3

* rename optimistic -> status

* Minor clean up

* revert loop variable change

* do not mark lvh as valid

Co-authored-by: terence tsao <terence@prysmaticlabs.com>
potuz added a commit that referenced this pull request May 17, 2022
@potuz
Merge pull request #3 from nisdas/addGithubActions
c2f630b 
Run Github Actions for GoHashtree Builds
mdehoog added a commit to mdehoog/prysm that referenced this pull request Jun 13, 2022
@mdehoog
TxPeekBlobVersionedHashes: fix hash copying (prysmaticlabs#3)
b3d2ed1
draganm pushed a commit to manifoldfinance/prysm that referenced this pull request Mar 13, 2023
@avalonche
Notify build block pre merge (prysmaticlabs#3)
1f179f4
MariusVanDerWijden pushed a commit to MariusVanDerWijden/prysm that referenced this pull request Aug 15, 2023
@infosecual
Merge pull request prysmaticlabs#3 from MariusVanDerWijden/mutation
11e421c 
fuzz_utils: add helper functions, cleanup on isle three
Redidacove referenced this pull request in Redidacove/prysm Aug 13, 2024
@taxmeifyoucan
Merge pull request #3 from arredr2/Participation-Guide-Update
a881d88 
Update participation-guide.md
potuz added a commit that referenced this pull request Mar 7, 2025
@potuz
Kasey's review #3
5f0fc28
potuz added a commit that referenced this pull request Mar 7, 2025
@potuz
Kasey's review #3
d2eb45c
github-merge-queue bot pushed a commit that referenced this pull request Mar 10, 2025
@potuz @nisdas
Add feature flag to start from any beacon block in db (#15000)
863eee7 
* Add feature flag to start from any beacon block in db

The new feature flag called --sync-from takes a string that can take
values:

- `head` or
- a 0x-prefixed hex encoded beacon block root.

The beacon block root or the head block root has to be known in db and
has to be a descendant of the current justified checkpoint.

* Fix Bugs In Sync From Head (#15006)

* Fix Bugs

* Remove log

* missing save

* add tests

* Kasey review #1

* Kasey's review #2

* Kasey's review #3

---------

Co-authored-by: Nishant Das <nishdas93@gmail.com>
rkapka pushed a commit that referenced this pull request Mar 19, 2025
@potuz @nisdas @rkapka
Add feature flag to start from any beacon block in db (#15000)
e033909 
* Add feature flag to start from any beacon block in db

The new feature flag called --sync-from takes a string that can take
values:

- `head` or
- a 0x-prefixed hex encoded beacon block root.

The beacon block root or the head block root has to be known in db and
has to be a descendant of the current justified checkpoint.

* Fix Bugs In Sync From Head (#15006)

* Fix Bugs

* Remove log

* missing save

* add tests

* Kasey review #1

* Kasey's review #2

* Kasey's review #3

---------

Co-authored-by: Nishant Das <nishdas93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

Assignees

@prestonvanloon prestonvanloon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@prestonvanloon @Magicking @rauljordan @fjl @shapeshed @karalabe