Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release To Fix 2.7 #988

Closed
chebee7i opened this issue Aug 16, 2019 · 15 comments
Closed

New Release To Fix 2.7 #988

chebee7i opened this issue Aug 16, 2019 · 15 comments

Comments

@chebee7i
Copy link

This is a redux #977 because I had some craziness going on in my paths.

The current release of black is 19.3b0 and it has a number of issues that affect 2.x code. These include:

Both issues are pretty terrible for code trying to be 2.x/3.x compatible, and both issues have been fixed in master. However, neither are part of a current release.

Can we get a new release out? If not, could we at least get a bugfix release out (19.3b1) that includes those two fixes?

@chebee7i
Copy link
Author

Is there anything holding this up? Or is it just that this project seems to have flatlined?

@chingc
Copy link

chingc commented Sep 19, 2019

There are plenty of commits each month so the project is still active. It would be nice to see a new beta release though.

Two workarounds until that happens:

  1. Use pre-commit which will let you specify a branch/tag/commit
  2. pip install git+https://github.com/psf/black.git@master

@chebee7i
Copy link
Author

Yeah, I've seen the commits...I question the priority though, as it seems like getting out a bug fix for a critical regression should be higher priority.

The minimal response on this and similar issues is, in part, a reason why one might question the overall status of the project.

Bottom line for me is that this release is broken, and the fix is really quite simple given that the commits are already integrated in master. Workarounds are fine but no replacement for fixing the release.

@JelleZijlstra
Copy link
Collaborator

I agree that it makes sense to get another (pre)release out ASAP, without waiting for other in-flight changes. @ambv @zsol what do you think?

@hugovk
Copy link
Contributor

hugovk commented Sep 30, 2019

+1 to a new beta (or better).

This (and isort, but there'll be a new isort release soon) is also blocking using Black on pip: pypa/pip#7084 (comment).

@zsol
Copy link
Collaborator

zsol commented Sep 30, 2019

I'm all in favor for more frequent releases in general so: yes 😎

@ambv
Copy link
Collaborator

ambv commented Sep 30, 2019

OK, let's do a new beta on Thursday. Let's flag what we can finish and merge until then.

@JelleZijlstra
Copy link
Collaborator

I just tested out current master on our codebase and unfortunately I found two new issues: #1041 and (more serious) #1042. I may have some time later to try to fix them.

@hugovk
Copy link
Contributor

hugovk commented Oct 3, 2019

Also #1044 from running master on pip. Possibly duplicates of those two.

@quasiben
Copy link

It does not seem like black was released on 2 weeks ago. Is a new release of black dependent on resolving:

@zsol
Copy link
Collaborator

zsol commented Oct 14, 2019

yes

@hugovk
Copy link
Contributor

hugovk commented Oct 29, 2019

Black 19.10b0 has just been released, can this be closed?

@ambv
Copy link
Collaborator

ambv commented Oct 29, 2019

I hope so. @chebee7i, can you confirm the new release fixed things for you?

@jd
Copy link

jd commented Nov 15, 2019

Latest version 19.10b0 fixes #752.

@tommyjcarpenter
Copy link

tommyjcarpenter commented Jun 19, 2020

Has this been switched to the stable branch? I am (per the vim instructions) using the latest stable version of black and I still hit this issue. I commented here: #988

It seems like the commit should be there: d6db1c1

However I am hitting this issue today (june 2020) with the latest stable black while editing python 2.7 code using let g:black_target_version=27 in vimrc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants