Add a list of stale issues #217
Conversation
Rishabh570
force-pushed
the
STALE
branch
2 times, most recently
from
c49a0d8 to
4a5222f
Compare
Rishabh570
changed the title
Rishabh570
added
ready
|
@jywarren @publiclab/reviewers Please take a look here, this is ready. |
|
@Rishabh570 one thing I think it exacerbates though is that the page is getting too long. What would you think of addressing #127 next? |
|
Thanks @sashadev-sky, I totally agree that page is really getting long. What if we add pagination for that, like only 10 stale issues per list and one can click next for more. Maybe later we can implement pagination for every list (like contributors, ftos, candidates, recent contributors) I can work on this next if we all decide to...what do you think? |
|
@jywarren Is it ready to merge? |
|
A couple suggestions - could we add a brief definition for "stale", so people know how these get sourced, and for the page getting long, we could have height = 1000 and overflow:scroll for each issues listing, what do you think? That could be simpler than pagination, although we'd want to be sure people know it's scroll-able! |
|
Yeah, sounds good. Setting overflow is easier than pagination.
What about something like, "this list contains issues which haven't been updated from the past 10 days"...this can be added as a note? |
|
Here's how it looks,
The scrollbar is pretty much visible but we can make it scroll just a little bit when a user hovers over it so that he/she notices it...what do you think? |
|
Autoscroll will surely catch the user's attention, it would look something like,
So as soon as the user hovers over the |
|
Hi @jywarren, should I include the changes responsible for that last GIF, in this PR? |
|
@jywarren Please review it also, I need to push if the changes look good. What do you think about the auto scrolling of the list...should we include it? |
|
This is so lovely. I really like the autoscroll touch. Fantastic work!!! |
|
I haven't pushed latest code here, if the latest GIF looks good I can push a fresh version here. |
|
Yes please!
…On Tue, Jun 25, 2019, 9:45 PM Rishabh Rawat ***@***.***> wrote:
I haven't pushed latest code here, if the latest GIF looks good I can push
a fresh version here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#217?email_source=notifications&email_token=AAAF6J22VTKQ63LMUTSH3SLP4LCYJA5CNFSM4HVCQZIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYSB7PQ#issuecomment-505683902>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6JZX6S22YQTX72RKM5LP4LCYJANCNFSM4HVCQZIA>
.
|
|
Added stale issues counter also,
|
|
@jywarren Ready. This and FTO authors' PR are ready for review. I'll be opening a PR for recent Contributors' logic refactorization which will allow us to be in a better position while writing code for various query times in the recent contribs list. |
|
@jywarren Please take a final look here :) |
|
@jywarren Is it ready to merge? |
|
:-) so awesome! Thank you! |
|
Can you publish to gh-pages? Maybe you should consider writing a blog post on publiclab.org describing the new features here! |
|
@jywarren Pushed to |
|
It looks awesome!!!!
…On Tue, Jul 9, 2019 at 8:03 PM Rishabh Rawat ***@***.***> wrote:
@jywarren <https://github.com/jywarren> Pushed to gh-pages just now...yes
I'll be writing a blog post about the work I've completed till now :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#217?email_source=notifications&email_token=AAAF6J6VZBBIAKCSBSTFSU3P6URKFA5CNFSM4HVCQZIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZR4DIY#issuecomment-509854115>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J3XZQXPMJRVB3E5CNTP6URKFANCNFSM4HVCQZIA>
.
|
* add stale issues list. * ensure flexibility of the text on index.html wherever needed. * fetch more stale issues by looping through pages of request. * Add stale list autoscroll.
Fixes #205
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!