Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed url link on image upload modal #1675 #1676

Merged
merged 2 commits into from
May 7, 2022

Conversation

PrajwalBorkar
Copy link
Contributor

Fixes #1675 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Apr 26, 2022

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Apr 26, 2022

@codeclimate
Copy link

codeclimate bot commented Apr 26, 2022

Code Climate has analyzed commit 95309b6 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #1676 (95309b6) into main (d501aa4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1676   +/-   ##
=======================================
  Coverage   71.89%   71.89%           
=======================================
  Files          40       40           
  Lines        1409     1409           
=======================================
  Hits         1013     1013           
  Misses        396      396           

@PeculiarE
Copy link
Contributor

Thank you ❤️ @PrajwalBorkar. This looks good 👍

@cesswairimu, could you please help review it? Thank you 😄

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 🎉 thanks for working on this @PrajwalBorkar 💯

@cesswairimu
Copy link
Collaborator

Thanks @PeculiarE for the reviews and the fto ❤️

@cesswairimu cesswairimu merged commit bc46b94 into publiclab:main May 7, 2022
@welcome
Copy link

welcome bot commented May 7, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@PeculiarE
Copy link
Contributor

It was a pleasure @cesswairimu ❤️ and congratulations @PrajwalBorkar 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use secure url link on image upload modal
3 participants