-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed url link on image upload modal #1675 #1676
Conversation
Fixed url link
Fixed url link on image upload modal publiclab#1675
Thanks for opening this pull request! |
Code Climate has analyzed commit 95309b6 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #1676 +/- ##
=======================================
Coverage 71.89% 71.89%
=======================================
Files 40 40
Lines 1409 1409
=======================================
Hits 1013 1013
Misses 396 396 |
Thank you ❤️ @PrajwalBorkar. This looks good 👍 @cesswairimu, could you please help review it? Thank you 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome 🎉 thanks for working on this @PrajwalBorkar 💯
Thanks @PeculiarE for the reviews and the fto ❤️ |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
It was a pleasure @cesswairimu ❤️ and congratulations @PrajwalBorkar 🎉🎉 |
Fixes #1675 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/mapknitter-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!