-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated _actvity.html.erb file #10009
Conversation
FTO completed
readme-updated
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## main #10009 +/- ##
==========================================
- Coverage 82.13% 82.06% -0.08%
==========================================
Files 98 98
Lines 5968 5976 +8
==========================================
+ Hits 4902 4904 +2
- Misses 1066 1072 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vacom13 can you enclose this into brackets like this <%=translation('tag.index.sort_by')%>
I had actually made an error and modified the issue later 😅 Thanks for contributing 🎉
Okay do I like create a new pull request? |
Hey @vacom13 you can just make another commit in this same branch for this change ✌️ |
Correction in line 69
Code Climate has analyzed commit 401d360 and detected 0 issues on this pull request. View more on Code Climate. |
Hey @Tlazypanda thank you for your help! I have made the required change. Hope its good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vacom13 Perfect!! 💯 Thanks for contributing ✌️
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
* readme-updated FTO completed * Update _activity.html.erb Correction in line 69
* readme-updated FTO completed * Update _activity.html.erb Correction in line 69
Changed the code on line 69 in the above file to
Change "Sort by" Strings to Translation Funtion Call.
Fixes #10001