Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated _actvity.html.erb file #10009

Merged
merged 3 commits into from
Aug 14, 2021
Merged

Conversation

vacom13
Copy link
Contributor

@vacom13 vacom13 commented Aug 10, 2021

Changed the code on line 69 in the above file to
Change "Sort by" Strings to Translation Funtion Call.

Fixes #10001

@welcome
Copy link

welcome bot commented Aug 10, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Aug 10, 2021

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #10009 (401d360) into main (f41f8e7) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10009      +/-   ##
==========================================
- Coverage   82.13%   82.06%   -0.08%     
==========================================
  Files          98       98              
  Lines        5968     5976       +8     
==========================================
+ Hits         4902     4904       +2     
- Misses       1066     1072       +6     
Impacted Files Coverage Δ
app/controllers/images_controller.rb 70.27% <100.00%> (ø)
app/controllers/notes_controller.rb 85.09% <100.00%> (+0.22%) ⬆️
app/helpers/application_helper.rb 87.62% <100.00%> (+2.21%) ⬆️
app/services/search_service.rb 95.00% <100.00%> (-0.10%) ⬇️
app/models/tag.rb 93.26% <0.00%> (-4.27%) ⬇️
app/controllers/user_tags_controller.rb 83.78% <0.00%> (+1.35%) ⬆️

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vacom13 can you enclose this into brackets like this <%=translation('tag.index.sort_by')%>
I had actually made an error and modified the issue later 😅 Thanks for contributing 🎉

@vacom13
Copy link
Contributor Author

vacom13 commented Aug 13, 2021

Okay do I like create a new pull request?

@Tlazypanda
Copy link
Collaborator

Hey @vacom13 you can just make another commit in this same branch for this change ✌️

Correction in line 69
@codeclimate
Copy link

codeclimate bot commented Aug 13, 2021

Code Climate has analyzed commit 401d360 and detected 0 issues on this pull request.

View more on Code Climate.

@vacom13
Copy link
Contributor Author

vacom13 commented Aug 13, 2021

Hey @Tlazypanda thank you for your help! I have made the required change. Hope its good now!

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vacom13 Perfect!! 💯 Thanks for contributing ✌️

@Tlazypanda Tlazypanda merged commit 8dd0f7a into publiclab:main Aug 14, 2021
@welcome
Copy link

welcome bot commented Aug 14, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* readme-updated

FTO completed

* Update _activity.html.erb

Correction in line 69
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* readme-updated

FTO completed

* Update _activity.html.erb

Correction in line 69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "Sort By" Strings to Translation Function Call in _activity.html.erb
2 participants