-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "Title" String to Translation Function Call #10073
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Codecov Report
@@ Coverage Diff @@
## main #10073 +/- ##
==========================================
- Coverage 82.13% 82.10% -0.04%
==========================================
Files 98 98
Lines 5968 5974 +6
==========================================
+ Hits 4902 4905 +3
- Misses 1066 1069 +3
|
Running the system tests again, they looked a bit buggy. |
Hey @sandipanpanda hope you have seen @noi5e response, if there are any further questions feel free to post here. We are here to help ❤️ |
Update _queue.html.erb according to changes requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sandipanpanda looks like we still have the changes at line 68 & 69 which are not required. Rest all looks good 👍
Code Climate has analyzed commit d8898b6 and detected 0 issues on this pull request. View more on Code Climate. |
@noi5e @Tlazypanda is this PR ok now? Can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for sticking with it!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Congrats @sandipanpanda, and welcome to Public Lab! |
* Change "Title" String to Translation Function Call publiclab#10053 * Update _queue.html.erb Update _queue.html.erb according to changes requested. * Update _queue.html.erb
* Change "Title" String to Translation Function Call publiclab#10053 * Update _queue.html.erb Update _queue.html.erb according to changes requested. * Update _queue.html.erb
Fixes #10053
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below