Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Title" String to Translation Function Call #10073

Merged
merged 3 commits into from
Sep 8, 2021

Conversation

sandipanpanda
Copy link
Contributor

@sandipanpanda sandipanpanda commented Aug 21, 2021

Fixes #10053

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Aug 21, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Aug 21, 2021

@sandipanpanda sandipanpanda changed the title Change "Title" String to Translation Function Call #10053 Change "Title" String to Translation Function Call Aug 21, 2021
@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #10073 (49a405f) into main (f41f8e7) will decrease coverage by 0.03%.
The diff coverage is 85.71%.

❗ Current head 49a405f differs from pull request most recent head d8898b6. Consider uploading reports for the commit d8898b6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10073      +/-   ##
==========================================
- Coverage   82.13%   82.10%   -0.04%     
==========================================
  Files          98       98              
  Lines        5968     5974       +6     
==========================================
+ Hits         4902     4905       +3     
- Misses       1066     1069       +3     
Impacted Files Coverage Δ
app/models/tag.rb 93.26% <44.44%> (-4.27%) ⬇️
app/controllers/home_controller.rb 96.05% <100.00%> (-2.62%) ⬇️
app/controllers/images_controller.rb 70.27% <100.00%> (ø)
app/controllers/notes_controller.rb 85.09% <100.00%> (+0.22%) ⬆️
app/controllers/tag_controller.rb 80.42% <100.00%> (ø)
app/helpers/application_helper.rb 87.62% <100.00%> (+2.21%) ⬆️
app/models/image.rb 82.05% <100.00%> (-0.45%) ⬇️
app/models/user.rb 86.12% <100.00%> (ø)
app/services/search_service.rb 94.89% <100.00%> (-0.21%) ⬇️
... and 5 more

@noi5e noi5e closed this Aug 21, 2021
@noi5e noi5e reopened this Aug 21, 2021
@noi5e
Copy link
Contributor

noi5e commented Aug 21, 2021

Running the system tests again, they looked a bit buggy.

@Tlazypanda
Copy link
Collaborator

Hey @sandipanpanda hope you have seen @noi5e response, if there are any further questions feel free to post here. We are here to help ❤️

Update _queue.html.erb according to changes requested.
@sandipanpanda sandipanpanda requested a review from noi5e August 26, 2021 19:02
Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sandipanpanda looks like we still have the changes at line 68 & 69 which are not required. Rest all looks good 👍

@codeclimate
Copy link

codeclimate bot commented Aug 30, 2021

Code Climate has analyzed commit d8898b6 and detected 0 issues on this pull request.

View more on Code Climate.

@sandipanpanda
Copy link
Contributor Author

@noi5e @Tlazypanda is this PR ok now? Can you please review?

Copy link
Contributor

@noi5e noi5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for sticking with it!

@noi5e noi5e merged commit 5271973 into publiclab:main Sep 8, 2021
@welcome
Copy link

welcome bot commented Sep 8, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@noi5e
Copy link
Contributor

noi5e commented Sep 8, 2021

Congrats @sandipanpanda, and welcome to Public Lab!

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
* Change "Title" String to Translation Function Call publiclab#10053

* Update _queue.html.erb

Update _queue.html.erb according to changes requested.

* Update _queue.html.erb
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
* Change "Title" String to Translation Function Call publiclab#10053

* Update _queue.html.erb

Update _queue.html.erb according to changes requested.

* Update _queue.html.erb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "Title" String to Translation Function Call
3 participants