Order tags based on best match to search query #9879

17sushmita · 2021-07-02T22:27:27Z

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

gitpod-io · 2021-07-02T22:27:30Z

codeclimate · 2021-07-02T22:28:18Z

app/services/search_service.rb

+        CASE
+          WHEN name LIKE "' + query + '" THEN 1
+          WHEN name LIKE "'+ query+'%" THEN 2
+          WHEN name LIKE "%'+ query +'" THEN 4


Surrounding space missing for operator +.

codeclimate · 2021-07-02T22:28:18Z

app/services/search_service.rb

+        CASE
+          WHEN name LIKE "' + query + '" THEN 1
+          WHEN name LIKE "'+ query+'%" THEN 2
+          WHEN name LIKE "%'+ query +'" THEN 4


Surrounding space missing for operator +.

codeclimate · 2021-07-02T22:28:18Z

app/services/search_service.rb

+      .order('
+        CASE
+          WHEN name LIKE "' + query + '" THEN 1
+          WHEN name LIKE "'+ query+'%" THEN 2


Surrounding space missing for operator +.

codeclimate · 2021-07-02T22:28:18Z

app/services/search_service.rb

+      .order('
+        CASE
+          WHEN name LIKE "' + query + '" THEN 1
+          WHEN name LIKE "'+ query+'%" THEN 2


Surrounding space missing for operator +.

codecov · 2021-07-02T22:33:42Z

Codecov Report

Merging #9879 (98bdff6) into main (1aaf43b) will decrease coverage by 56.01%.
The diff coverage is 30.76%.

❗ Current head 98bdff6 differs from pull request most recent head b1c2144. Consider uploading reports for the commit b1c2144 to get more accurate results

@@             Coverage Diff             @@
##             main    #9879       +/-   ##
===========================================
- Coverage   82.06%   26.05%   -56.02%     
===========================================
  Files          98       98               
  Lines        5945     7629     +1684     
===========================================
- Hits         4879     1988     -2891     
- Misses       1066     5641     +4575

Impacted Files	Coverage Δ
app/channels/room_channel.rb	`0.00% <0.00%> (-71.43%)`	⬇️
app/controllers/stats_controller.rb	`0.00% <0.00%> (-71.58%)`	⬇️
app/controllers/tag_controller.rb	`0.00% <0.00%> (-79.82%)`	⬇️
app/models/tag.rb	`91.54% <0.00%> (-5.96%)`	⬇️
app/helpers/application_helper.rb	`37.50% <16.66%> (-47.92%)`	⬇️
app/models/node.rb	`76.11% <75.00%> (-14.90%)`	⬇️
app/models/user.rb	`76.51% <75.00%> (-9.51%)`	⬇️
app/services/search_service.rb	`64.70% <100.00%> (-30.35%)`	⬇️
app/controllers/talk_controller.rb	`0.00% <0.00%> (-100.00%)`	⬇️
app/mailers/password_reset_mailer.rb	`0.00% <0.00%> (-100.00%)`	⬇️
... and 60 more

namangupta01 · 2021-07-04T18:12:32Z

app/services/search_service.rb

@@ -84,6 +84,13 @@ def search_tags(query, limit = 10)
      .includes(:node)
      .references(:node)
      .where('node.status = 1')
+      .order('
+        CASE


Hey!
Just a quick suggestion can we store the case string in a variable and then just use that inside order?
For example: tags_order = "CASE WHEN name like #{query} THEN 1 WHEN name LIKE #{query}% THEN 2 WHEN name LIKE %{query} THEN 4 ELSE 3"
and then just use order(tags_order).

Also, should we include one more case? WHEN name like %#{query}%

@namangupta01, the first suggestion seems to be a good idea to store the string as a variable and using it. I'm adding a commit with the changes.
As per WHEN name like %#{query}% case is concerned, I think it will show up in the ELSE condition as it is the only condition left for else ig. What do you think?

Hi @namangupta01, kindly give this another look when you get some time. Thanks and nice to you see around!

namangupta01

Just a couple of suggestions. Other than this everything looks great. 👍

codeclimate · 2021-07-05T14:51:59Z

app/services/search_service.rb

@@ -78,12 +78,16 @@ def search_maps(input, limit = 25, order = :natural, type = :boolean)
  # chained to the notes that are tagged with those values
  def search_tags(query, limit = 10)
    suggestions = []
+    # order tag autosuggestions by placing exact match of the tag on the top, then tags with query and some other text as suffix, 
+    # then tags with some text as prefix or suffix and lastly the tags with some text as prefix
+    tags_order = 'CASE WHEN name LIKE ? OR name LIKE ? THEN 1 WHEN name LIKE ? OR name LIKE ? THEN 2 WHEN name LIKE ? OR name LIKE ? THEN 4 ELSE 3 END', "#{query}", "#{query.to_s.gsub(' ', '-')}", "#{query}%", "#{query.to_s.gsub(' ', '-')}%", "%#{query}", "%#{query.to_s.gsub(' ', '-')}"


Prefer to_s over string interpolation.

codeclimate · 2021-07-05T14:52:00Z

app/services/search_service.rb

@@ -78,12 +78,16 @@ def search_maps(input, limit = 25, order = :natural, type = :boolean)
  # chained to the notes that are tagged with those values
  def search_tags(query, limit = 10)
    suggestions = []
+    # order tag autosuggestions by placing exact match of the tag on the top, then tags with query and some other text as suffix, 
+    # then tags with some text as prefix or suffix and lastly the tags with some text as prefix
+    tags_order = 'CASE WHEN name LIKE ? OR name LIKE ? THEN 1 WHEN name LIKE ? OR name LIKE ? THEN 2 WHEN name LIKE ? OR name LIKE ? THEN 4 ELSE 3 END', "#{query}", "#{query.to_s.gsub(' ', '-')}", "#{query}%", "#{query.to_s.gsub(' ', '-')}%", "%#{query}", "%#{query.to_s.gsub(' ', '-')}"


Prefer to_s over string interpolation.

jywarren · 2021-07-06T15:24:40Z

Trying to resolve in #9873

jywarren · 2021-07-06T16:46:43Z

Sorry this is so annoying! I actually just merged #9881 so if you'd like to try rebasing over it it might help!

codeclimate · 2021-07-07T14:12:02Z

Code Climate has analyzed commit b1c2144 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Style	2

View more on Code Climate.

cesswairimu

This is looking good 🎉 🎉

We can ignore code climate warnings...let me know if we are good to merge...Thanks @17sushmita 🎉 🎉

17sushmita · 2021-07-11T22:51:20Z

This is looking good

We can ignore code climate warnings...let me know if we are good to merge...Thanks @17sushmita

Yes, we are good to merge @cesswairimu. Thanks 😄

jywarren · 2021-07-13T18:22:27Z

Looks great! I resolved the CodeClimate and for some reason the CodeCov error just went away instantly. 🤷

ebarry · 2021-07-21T16:07:29Z

this is so great!

bhamster07 · 2021-07-21T17:39:06Z

Hooray, thanks so much everyone!! 😀

* order tags based on best match to search query * minor changes in ordering tags based on best match

codeclimate bot reviewed Jul 2, 2021

View reviewed changes

namangupta01 reviewed Jul 4, 2021

View reviewed changes

namangupta01 requested changes Jul 4, 2021

View reviewed changes

codeclimate bot reviewed Jul 5, 2021

View reviewed changes

jywarren mentioned this pull request Jul 6, 2021

Periodic test failures in GitHub Actions CI and CodeCov #9873

Closed

17sushmita requested review from a team as code owners July 7, 2021 13:58

17sushmita added 2 commits July 7, 2021 19:40

order tags based on best match to search query

6d0fbce

minor changes in ordering tags based on best match

b1c2144

17sushmita force-pushed the tag-matching-bug branch from 3453e23 to b1c2144 Compare July 7, 2021 14:11

publiclab deleted a comment from codeclimate bot Jul 7, 2021

cesswairimu approved these changes Jul 10, 2021

View reviewed changes

jywarren merged commit 6832a43 into publiclab:main Jul 13, 2021

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021

Order tags based on best match to search query (publiclab#9879)

e954bc3

* order tags based on best match to search query * minor changes in ordering tags based on best match

billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021

Order tags based on best match to search query (publiclab#9879)

11cdeaa

* order tags based on best match to search query * minor changes in ordering tags based on best match

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Order tags based on best match to search query #9879

Order tags based on best match to search query #9879

17sushmita commented Jul 2, 2021

gitpod-io bot commented Jul 2, 2021

codeclimate bot Jul 2, 2021

codeclimate bot Jul 2, 2021

codeclimate bot Jul 2, 2021

codeclimate bot Jul 2, 2021

codecov bot commented Jul 2, 2021 •

edited

Loading

namangupta01 Jul 4, 2021 •

edited

Loading

17sushmita Jul 5, 2021

cesswairimu Jul 10, 2021

namangupta01 left a comment

codeclimate bot Jul 5, 2021

codeclimate bot Jul 5, 2021

jywarren commented Jul 6, 2021

jywarren commented Jul 6, 2021

codeclimate bot commented Jul 7, 2021

cesswairimu left a comment

17sushmita commented Jul 11, 2021

jywarren commented Jul 13, 2021

ebarry commented Jul 21, 2021

bhamster07 commented Jul 21, 2021

Order tags based on best match to search query #9879

Order tags based on best match to search query #9879

Conversation

17sushmita commented Jul 2, 2021

gitpod-io bot commented Jul 2, 2021

codeclimate bot Jul 2, 2021

Choose a reason for hiding this comment

codeclimate bot Jul 2, 2021

Choose a reason for hiding this comment

codeclimate bot Jul 2, 2021

Choose a reason for hiding this comment

codeclimate bot Jul 2, 2021

Choose a reason for hiding this comment

codecov bot commented Jul 2, 2021 • edited Loading

Codecov Report

namangupta01 Jul 4, 2021 • edited Loading

Choose a reason for hiding this comment

17sushmita Jul 5, 2021

Choose a reason for hiding this comment

cesswairimu Jul 10, 2021

Choose a reason for hiding this comment

namangupta01 left a comment

Choose a reason for hiding this comment

codeclimate bot Jul 5, 2021

Choose a reason for hiding this comment

codeclimate bot Jul 5, 2021

Choose a reason for hiding this comment

jywarren commented Jul 6, 2021

jywarren commented Jul 6, 2021

codeclimate bot commented Jul 7, 2021

cesswairimu left a comment

Choose a reason for hiding this comment

17sushmita commented Jul 11, 2021

jywarren commented Jul 13, 2021

ebarry commented Jul 21, 2021

bhamster07 commented Jul 21, 2021

codecov bot commented Jul 2, 2021 •

edited

Loading

namangupta01 Jul 4, 2021 •

edited

Loading