Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include concat::setup from concat, so users don't need to #27

Merged
merged 1 commit into from
Jul 11, 2012

Conversation

djmitche
Copy link
Contributor

This includes concat::setup directly from concat, so users don't have to. Of course, it won't hurt to include it manually, too.

This should fix #gh-16.

I'm not sure what @dalen meant in his last comment there, about resource defaults. I'll revise if you can clarify.

ripienaar added a commit that referenced this pull request Jul 11, 2012
Include concat::setup from concat, so users don't need to
@ripienaar ripienaar merged commit a0661e1 into puppetlabs:master Jul 11, 2012
@ripienaar
Copy link
Contributor

likely cause hassles in future puppet but will deal with that when it happens

thanks

@dalen
Copy link
Contributor

dalen commented Jul 14, 2012

I meant that the line:
$group = $concat::setup::root_group,

in the parameters section of concat requires concat::setup to be parsed already. so it should really inherit from concat::setup using the style mentioned at http://docs.puppetlabs.com/guides/style_guide.html#class-parameter-defaults that requires 2.6.3 or later. But I'm not sure if you want to break 2.6.2 compatibility just yet as it is the version still used in debian stable for example.

@ripienaar
Copy link
Contributor

yes, wouldnt want to break backwards compat with 2.6.x

@djmitche
Copy link
Contributor Author

Ah, I didn't spot that. Could you set the default to a sentinel value, and substitute it in the class itself (where the value is available)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants