Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do ClassName, AttrName, and PropName types belong here instead of web-html? #56

Open
nsaunders opened this issue May 11, 2023 · 1 comment

Comments

@nsaunders
Copy link
Contributor

nsaunders commented May 11, 2023

purescript-web/purescript-web-html#30 migrated the ClassName, AttrName, and PropName types from Halogen to web-html.

Considering several relevant functions in Web.DOM.Element (className, setClassName, getAttribute, setAttribute, hasAttribute, and removeAttribute), I wonder why web-html was determined to be the right place for these types rather than web-dom?

And, for that matter, should the above-listed functions not make use of these ClassName and AttrName types? (The situation today is understandable, of course, in that web-dom can't/shouldn't depend on web-html.)

@nsaunders nsaunders mentioned this issue May 11, 2023
1 task
@garyb
Copy link
Member

garyb commented May 12, 2023

Yeah, moving those here makes sense to me. It could be that they were created on the other repo because Miles was unaware/forgot about the existence of this one 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants