Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttrName, ClassName, PropName, and ElementId types. Resolves #56 and #57. #58

Merged

Conversation

nsaunders
Copy link
Contributor

Prerequisites

  • Before opening a pull request, please check the DOM standard (https://dom.spec.whatwg.org/). If it doesn't appear in this spec, it may be present in the spec for one of the other purescript-web projects. Although MDN is a great resource, it is not a suitable reference for this project.

Description of the change

With this change, the AttrName, ClassName, and PropName types are migrated from web-html. A few relevant functions are also updated to use these instead of strings. (This wasn't possible before because web-html depends on web-dom, not the other way around.) See #56 for the original change request.

Similar to the types above, a new ElementId type represents the value of an id attribute/property, and the id and setId functions are updated accordingly. This resolves #57.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable) N/A

Sorry, something went wrong.

@nsaunders nsaunders changed the title AttrName, ClassName, PropName, and ElementId types AttrName, ClassName, PropName, and ElementId types. Resolves #56 and #57. May 13, 2023
@garyb
Copy link
Member

garyb commented Sep 24, 2023

I'm not sure why I didn't merge this at the time I approved it, sorry!

@garyb garyb merged commit 8dde115 into purescript-web:master Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElementId type
2 participants