Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

groupBy is not stable #147

Closed
dederer opened this issue Sep 18, 2018 · 2 comments
Closed

groupBy is not stable #147

dederer opened this issue Sep 18, 2018 · 2 comments

Comments

@dederer
Copy link

dederer commented Sep 18, 2018

In following example:

arr :: Array Int
arr = [1,2,3,4,5]

test :: String
test = show $ A.groupBy (\_ _ -> true) arr

Expected value of the function test:

[(NonEmptyArray [1,2,3,4,5])]

Actually:

[(NonEmptyArray [2,3,4,5,1])]

The first element is placed at the end of array.
@LiamGoodacre LiamGoodacre mentioned this issue Sep 19, 2018
Merged
@LiamGoodacre
Copy link
Member

Thanks for reporting!

fsoikin added a commit to fsoikin/purescript-arrays that referenced this issue Sep 20, 2018
@fsoikin
groupBy shouldn't reorder the elements. Fixes purescript#147
4ee4619
@LiamGoodacre
Copy link
Member

Released in v5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LiamGoodacre @dederer