Improve outer border behaviour with nonzero gutter #1087
Conversation
Header rows need gutter between them, as well as before the start of content; see test_table_with_colspan()
mjasperse
force-pushed
the
feature/1071_outer_border_gutter
branch
from
e1f60f1 to
0173731
Compare
Outer border top and bottom lines are now single continuous lines instead of many line segments
|
The additional fix about the table header is that after a pagebreak the gutter height was not added - see |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1087 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 29 29
Lines 8556 8566 +10
Branches 1577 1578 +1
=======================================
+ Hits 8000 8010 +10
Misses 344 344
Partials 212 212 ☔ View full report in Codecov by Sentry. |
| filename = HERE / f"{name}.pdf" | ||
| assert_pdf_equal(pdf, filename, tmp_path, generate=False) | ||
| assert_pdf_equal(pdf, filename, tmp_path, generate=generate) |
There was a problem hiding this comment.
I don't see a reason to leave the generate parameter here but it's not a showstopper.
|
Thank you for your contribution @mjasperse |
Festive greetings and Happy New Year to the team!
This PR fixes #1071 for the combination of simultaneous outer border and gutter by making the outer border line continuous and inserting gutter spacing inside the border
Checklist:
The GitHub pipeline is OK (green),
meaning that both
pylint(static code analyzer) andblack(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
N/A In case of a new feature, docstrings have been added, with also some documentation in the
docs/folderA mention of the change is present in
CHANGELOG.mdBy submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.