Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Simplify file identifiers generation #2003

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Merge branch 'main' into simplify

e325c79
Select commit
Loading
Failed to load commit list.
Open

MAINT: Simplify file identifiers generation #2003

Merge branch 'main' into simplify
e325c79
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 20, 2024 in 0s

95.13% (-0.02%) compared to 4a41c53, passed because coverage increased by -0.01% when compared to adjusted base (95.14%)

View this Pull Request on Codecov

95.13% (-0.02%) compared to 4a41c53, passed because coverage increased by -0.01% when compared to adjusted base (95.14%)

Details

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.13%. Comparing base (4a41c53) to head (e325c79).

Files Patch % Lines
pypdf/_writer.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2003      +/-   ##
==========================================
- Coverage   95.14%   95.13%   -0.02%     
==========================================
  Files          51       51              
  Lines        8551     8551              
  Branches     1706     1707       +1     
==========================================
- Hits         8136     8135       -1     
  Misses        261      261              
- Partials      154      155       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.