Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Ease access to ViewerPreferences #2144

Merged
merged 7 commits into from
Sep 5, 2023
Merged

ENH: Ease access to ViewerPreferences #2144

merged 7 commits into from
Sep 5, 2023

Conversation

pubpub-zz
Copy link
Collaborator

closes #2105
still doc and test to be fixed/added

@pubpub-zz
ENH : ease access to ViewerPreferences
6f3a50e 
closes py-pdf#2105
still doc and test to be fixed/added
@pubpub-zz
Copy link
Collaborator Author

@MartinThoma
Can you give me your opinion on this first part

@codecov
Copy link

codecov bot commented Sep 3, 2023 •
edited
Loading

Codecov Report

Patch coverage: 97.75% and project coverage change: +0.09% 🎉

Comparison is base (301b542) 94.13% compared to head (2d487b1) 94.22%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2144      +/-   ##
==========================================
+ Coverage   94.13%   94.22%   +0.09%     
==========================================
  Files          41       42       +1     
  Lines        7467     7556      +89     
  Branches     1474     1487      +13     
==========================================
+ Hits         7029     7120      +91     
+ Misses        273      268       -5     
- Partials      165      168       +3
Files Changed Coverage Δ
pypdf/_reader.py 91.69% <88.88%> (-0.03%) ⬇️
pypdf/_writer.py 88.25% <94.11%> (+0.41%) ⬆️
pypdf/generic/__init__.py 100.00% <100.00%> (ø)
pypdf/generic/_viewerpref.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pubpub-zz
Copy link
Collaborator Author

@MartinThoma I've been as far as possible. I have not been able to check if documentation is properly generated

@MartinThoma MartinThoma changed the title ENH : ease access to ViewerPreferences ENH: Ease access to ViewerPreferences Sep 3, 2023
@MartinThoma MartinThoma added the soon PRs that are almost ready to be merged, issues that get solved pretty soon label Sep 3, 2023
@MartinThoma
Copy link
Member

Looks good to me :-) Nice work 🚀

I've seen that there was a draft PR: https://github.com/py-pdf/pypdf/commit/c95b694068d00184dfc8a9b7dceabf7446839ccd.patch

If you used that one, I would mere it with Co-authored-by: Marc Stober if that is also fine to you. If you didn't use that one or if you don't think that makes sense, I'll merge it as it is. Just let me know :-)

@pubpub-zz
Copy link
Collaborator Author

Looks good to me :-) Nice work 🚀

I've seen that there was a draft PR: https://github.com/py-pdf/pypdf/commit/c95b694068d00184dfc8a9b7dceabf7446839ccd.patch

If you used that one, I would mere it with Co-authored-by: Marc Stober if that is also fine to you. If you didn't use that one or if you don't think that makes sense, I'll merge it as it is. Just let me know :-)

I looked at it but there is a few errors. However I'm completly open to Co-authored it 😀

@MartinThoma MartinThoma merged commit 05f2a65 into py-pdf:main Sep 5, 2023
marcstober added a commit to marcstober/pypdf that referenced this pull request Sep 7, 2023
@marcstober
Proposed change to py-pdf#2144
11ddc7b
marcstober added a commit to marcstober/pypdf that referenced this pull request Sep 7, 2023
@marcstober
Proposed change to py-pdf#2144
5ae75af
marcstober added a commit to marcstober/pypdf that referenced this pull request Sep 7, 2023
@marcstober
DOC: Fix typos in docstrings (see py-pdf#2144)
bb31a3b
@MartinThoma MartinThoma mentioned this pull request Sep 8, 2023
Merged
MartinThoma pushed a commit that referenced this pull request Sep 8, 2023
@marcstober
DOC: Typos in ViewerPreferences docstrings (#2169)
bd73243 
See #2144
@MartinThoma MartinThoma mentioned this pull request Sep 7, 2023
Closed
MartinThoma added a commit that referenced this pull request Sep 10, 2023
@MartinThoma
REL: 3.16.0
fb35485 
## What's new

### Security (SEC)
-  Infinite recursion caused by IndirectObject clone (#2156)

### New Features (ENH)
-  Ease access to ViewerPreferences (#2144)

### Bug Fixes (BUG)
-  catch the case where w[0] is an IndirectObject instead of an int (#2154)
-  Cope with indirect objects in filters and remove deprecated code (#2177)
-  Cope with extra space (#2151)
-  Merge pages without resources (#2150)
-  getcontents() shall return None if contents is NullObject (#2161)
-  Fix conversion from 1 to LA (#2175)
-  Accept tabs in cmaps (#2174)

### Robustness (ROB)
-  Accept XYZ with no arguments (#2178)

[Full Changelog](3.15.5...3.16.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinThoma MartinThoma MartinThoma left review comments

Assignees
No one assigned
Labels
soon PRs that are almost ready to be merged, issues that get solved pretty soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support right-to-left ViewerPreferences
2 participants
@pubpub-zz @MartinThoma