BUG: clean_forms function cause infinite looping if elt["/Resources"] have circular relation #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to recheck mypy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have several PDF files from customers, and using
remove_textcan cause infinite looping. Upon investigation, I discovered a corner case whereelt["/Resources"]has a circular relation, which can result in callingclean_forms(content, stack + [elt])infinitely.I proposed keeping a memory variable
visited_resourcesto keep track of whichelt["/Resources"]has been processed and to avoid infinite looping.The corner case files are private and cannot be shared, but I believe many people would encounter the same problem.
Closes #2474