Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STY: Remove an unnecessary else #3179

Merged
merged 4 commits into from
Mar 13, 2025
Merged

STY: Remove an unnecessary else #3179

merged 4 commits into from
Mar 13, 2025

Conversation

j-t-1
Copy link
Contributor

@j-t-1 j-t-1 commented Mar 12, 2025

No description provided.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (56220ab) to head (beab7f2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3179      +/-   ##
==========================================
+ Coverage   96.51%   96.53%   +0.02%     
==========================================
  Files          53       53              
  Lines        8927     8928       +1     
  Branches     1639     1640       +1     
==========================================
+ Hits         8616     8619       +3     
+ Misses        187      186       -1     
+ Partials      124      123       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefan6419846
Copy link
Collaborator

It seems like we never had a test for this case. Are you able to provide one yourself or should I have a look into this?

@stefan6419846 stefan6419846 added the needs-test A test should be added before this PR is merged. label Mar 13, 2025
@j-t-1
Copy link
Contributor Author

j-t-1 commented Mar 13, 2025

If you could that would be cool.

@stefan6419846 stefan6419846 removed the needs-test A test should be added before this PR is merged. label Mar 13, 2025
@stefan6419846 stefan6419846 merged commit 016fef2 into py-pdf:main Mar 13, 2025
16 checks passed
@j-t-1 j-t-1 deleted the else branch March 13, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants