-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Basemap dependency #180
Conversation
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
==========================================
+ Coverage 74.40% 74.80% +0.40%
==========================================
Files 110 110
Lines 8802 8736 -66
==========================================
- Hits 6549 6535 -14
+ Misses 2253 2201 -52
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @dnerini! Looks ready to go!
Nice work! I'm wondering should we still keep the plot_map option in the interface. In addition to cartopy, there are quite many map plotting tools that could be supported in future releases of pysteps. |
It's a good point, it would also improve back-compatibility and provide a clear way to not plot a basemap ( edit: done in e5fed04 |
This PR removes the support for the Basemap module. As a consequence, all drawing of geographical features will be based on Cartopy only.
In detail:
drawlonlatlabels
option (closes Axis tick labels with lon-lat lines #14)scale in ["10m", "50M"]
.geodata
without Cartopy installed silently fails, producing a georeferenced plot without any basemap (which is equivalent to passplot_map=None
).See below for plots using pysteps example data: