#644 tighter default tols for testing

Author: rtimms

tests/integration/test_models/standard_model_tests.py

@@ -71,6 +71,10 @@ def test_solving(self, solver=None, t_eval=None):
         # Overwrite solver if given
         if solver is not None:
             self.solver = solver
+        else:
+            # use tighter default tolerances for testing
+            self.solver.rtol = 1e-8
+            self.solver.atol = 1e-8
         if t_eval is None:
             t_eval = np.linspace(0, 1, 100)
 

tests/unit/test_processed_variable.py

@@ -383,10 +383,7 @@ def test_processed_variable_ode_pde_solution(self):
         model.rhs = {c: -c}
         model.initial_conditions = {c: 1}
         model.variables = {"c": c}
-        solver = model.default_solver
-        solver.rtol = 1e-8
-        solver.atol = 1e-8
-        modeltest = tests.StandardModelTest(model, solver=solver)
+        modeltest = tests.StandardModelTest(model)
         modeltest.test_all()
         t_sol, y_sol = modeltest.solution.t, modeltest.solution.y
         processed_vars = pybamm.post_process_variables(model.variables, t_sol, y_sol)
@@ -410,10 +407,7 @@ def test_processed_variable_ode_pde_solution(self):
             "c_s": c_s,
             "N_s": pybamm.grad(c_s),
         }
-        solver = model.default_solver
-        solver.rtol = 1e-8
-        solver.atol = 1e-8
-        modeltest = tests.StandardModelTest(model, solver=solver)
+        modeltest = tests.StandardModelTest(model)
         modeltest.test_all()
         # set up testing
         t_sol, y_sol = modeltest.solution.t, modeltest.solution.y