Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set relative and absolute tolerances separately for solver #644

Closed
rtimms opened this issue Oct 2, 2019 · 0 comments · Fixed by #645
Closed

set relative and absolute tolerances separately for solver #644

rtimms opened this issue Oct 2, 2019 · 0 comments · Fixed by #645
Assignees
@rtimms

Comments

@rtimms
Copy link
Contributor

rtimms commented Oct 2, 2019

At the moment we use the same tol for both. Would be good to have additional control over these. Also, the defaults are pretty tight so we might relax them a bit to get a good balance of speed and accuracy.
@rtimms rtimms self-assigned this Oct 3, 2019
rtimms added a commit that referenced this issue Oct 3, 2019
@rtimms
#644 set atol and rtol
783d230
@rtimms rtimms mentioned this issue Oct 3, 2019
Merged
7 tasks
rtimms added a commit that referenced this issue Oct 3, 2019
@rtimms
#644 tighter default tols for testing
3a0dc1c
rtimms added a commit that referenced this issue Oct 3, 2019
@rtimms
#644 reduce rtol
184515d
rtimms added a commit that referenced this issue Oct 3, 2019
@rtimms
#644 tino comments
752c72b
rtimms added a commit that referenced this issue Oct 4, 2019
@rtimms
#644 fix atol docstring
3da5c5d
rtimms added a commit that referenced this issue Oct 7, 2019
@rtimms
Merge pull request #645 from pybamm-team/issue-644-solver-tol
30c4f80 
#644 set atol and rtol
valentinsulzer pushed a commit that referenced this issue Feb 10, 2020
#644 fix typo in name
e3d2171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtimms rtimms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#644 set atol and rtol pybamm-team/PyBaMM
1 participant
@rtimms