Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initializing a model #1194

Closed
valentinsulzer opened this issue Oct 17, 2020 · 0 comments · Fixed by #1278
Closed

Initializing a model #1194

valentinsulzer opened this issue Oct 17, 2020 · 0 comments · Fixed by #1278
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

Add an example for how to change the initial conditions of a model (e.g. to initialize a model with a different model). Need to make sure this doesn't run into problems with how model.new_copy is implemented. If relevant, add a helper function to allow this
@valentinsulzer valentinsulzer mentioned this issue Dec 2, 2020
Closed
@valentinsulzer valentinsulzer self-assigned this Dec 4, 2020
valentinsulzer added a commit that referenced this issue Dec 5, 2020
@valentinsulzer
#1194 #1205 first go at reformatting new_copy
1e8426e
valentinsulzer added a commit that referenced this issue Dec 6, 2020
@valentinsulzer
#1194 add helper function for initializing initial conditions
88d1edd
valentinsulzer added a commit that referenced this issue Dec 6, 2020
@valentinsulzer
#1194 fix tests
3b93a0d
valentinsulzer added a commit that referenced this issue Dec 6, 2020
@valentinsulzer
#1194 fix test
2917c1e
valentinsulzer added a commit that referenced this issue Dec 6, 2020
@valentinsulzer
#1194 fix docs
f56e778
valentinsulzer added a commit that referenced this issue Dec 6, 2020
@valentinsulzer
#1194 test initializing with a different model
5cca52e
valentinsulzer added a commit that referenced this issue Dec 6, 2020
@valentinsulzer
#1194 fix example
f95a946
valentinsulzer added a commit that referenced this issue Dec 6, 2020
@valentinsulzer
#1194 add option to use dictionary instead of Solution
c77eda2
valentinsulzer added a commit that referenced this issue Dec 6, 2020
@valentinsulzer
#1194 coverage
1fa3d2f
valentinsulzer added a commit that referenced this issue Dec 6, 2020
@valentinsulzer
#1194 fix notebook
c2c797b
@valentinsulzer valentinsulzer mentioned this issue Dec 7, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Dec 7, 2020
@valentinsulzer
#1194 coverage and changelog
2012162
valentinsulzer added a commit that referenced this issue Dec 7, 2020
@valentinsulzer
#1194 coverage
0ade46e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1194 initial conditions pybamm-team/PyBaMM
1 participant
@valentinsulzer