We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary
Currently, the 1+1D pouch cell model only works for both cells on the top.
Motivation
For pouch cells with tabs on opposite sides, the 1D model is particularly useful as they are symmetric in the y direction.
Additional context
https://github.com/pybamm-team/PyBaMM/blob/develop/pybamm/models/full_battery_models/base_battery_model.py#L302-L306
https://github.com/pybamm-team/PyBaMM/blob/develop/pybamm/models/submodels/thermal/pouch_cell/pouch_cell_1D_current_collectors.py#L98
The text was updated successfully, but these errors were encountered:
#1571 allow tabs on bottom in 1+1D thermal model
95f6740
#1571 fix test
9c2ee1b
#1571 changelog
3377317
#1571 coverage
f62b7a3
#1571 remove events in particle distribution submodels
eaf54f3
Awesome, thanks @rtimms! 🎉
Sorry, something went wrong.
rtimms
Successfully merging a pull request may close this issue.
Summary
Currently, the 1+1D pouch cell model only works for both cells on the top.
Motivation
For pouch cells with tabs on opposite sides, the 1D model is particularly useful as they are symmetric in the y direction.
Additional context
https://github.com/pybamm-team/PyBaMM/blob/develop/pybamm/models/full_battery_models/base_battery_model.py#L302-L306
https://github.com/pybamm-team/PyBaMM/blob/develop/pybamm/models/submodels/thermal/pouch_cell/pouch_cell_1D_current_collectors.py#L98
The text was updated successfully, but these errors were encountered: