Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1D current collectors with opposite-sided tabs #1571

Closed
DavidMStraub opened this issue Jul 28, 2021 · 1 comment · Fixed by #1581
Closed

1D current collectors with opposite-sided tabs #1571

DavidMStraub opened this issue Jul 28, 2021 · 1 comment · Fixed by #1581
Assignees
@rtimms

Comments

@DavidMStraub
Copy link
Contributor

Summary

Currently, the 1+1D pouch cell model only works for both cells on the top.

Motivation

For pouch cells with tabs on opposite sides, the 1D model is particularly useful as they are symmetric in the y direction.

Additional context

https://github.com/pybamm-team/PyBaMM/blob/develop/pybamm/models/full_battery_models/base_battery_model.py#L302-L306

https://github.com/pybamm-team/PyBaMM/blob/develop/pybamm/models/submodels/thermal/pouch_cell/pouch_cell_1D_current_collectors.py#L98
@rtimms rtimms self-assigned this Jul 29, 2021
rtimms added a commit that referenced this issue Jul 29, 2021
@rtimms
#1571 allow tabs on bottom in 1+1D thermal model
95f6740
rtimms added a commit that referenced this issue Jul 29, 2021
@rtimms
#1571 fix test
9c2ee1b
@rtimms rtimms mentioned this issue Jul 29, 2021
Merged
8 tasks
rtimms added a commit that referenced this issue Jul 29, 2021
@rtimms
#1571 changelog
3377317
rtimms added a commit that referenced this issue Aug 2, 2021
@rtimms
#1571 coverage
f62b7a3
rtimms added a commit that referenced this issue Aug 6, 2021
@rtimms
#1571 remove events in particle distribution submodels
eaf54f3
@DavidMStraub
Copy link
Contributor Author

Awesome, thanks @rtimms! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtimms rtimms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1571 1 d cc opposite tabs pybamm-team/PyBaMM
2 participants
@DavidMStraub @rtimms