-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jacobian by equation #651
Comments
something that might help is checking if any state vectors are in the tree in the base method for jac here and returning zeros of the right shape if not. not sure how often it happens but it might avoid calculating jac down a particular branch unnecessarily. should at least stop the tree for jac becoming so large |
Can this now be closed @rtimms ? |
yep. the functionality is there to do this if calculating the jacobian using the method in |
Summary
Perform the Jacobian calculation on each individual equation and then concatenate the result.
Also simplify by equation.
Reason
Currently, we discretize equations and then combine into one large concatenated vector. This leads to very large expression tree which are lead to issues with RAM and are hard to interpret. We can instead simply hold off concatenating the discretized equations (i.e. move this step to the solver) and take the Jacobian of each equation individually. This helps with a few things:
The text was updated successfully, but these errors were encountered: