Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jacobian class #665

Closed
rtimms opened this issue Oct 16, 2019 · 2 comments · Fixed by #670
Closed

Jacobian class #665

rtimms opened this issue Oct 16, 2019 · 2 comments · Fixed by #670
Assignees
@rtimms

Comments

@rtimms
Copy link
Contributor

rtimms commented Oct 16, 2019

Create a class for Jacobian similar to Simplification that reuses known jacobians
@rtimms rtimms self-assigned this Oct 16, 2019
rtimms added a commit that referenced this issue Oct 16, 2019
@rtimms
#665 add jacobian class
d1acc43
@Scottmar93
Copy link
Contributor

maybe we want to be careful about storing used Jacobians if RAM has been an issue when calculating the jacobian. If this becomes an issue, we could set a flag on specific symbols so that they can be stored and not others (e.g. the i_cc term in the 2+1D case).

@Scottmar93
Copy link
Contributor

just do this along with #651 ?

rtimms added a commit that referenced this issue Oct 18, 2019
@rtimms
#665 make binary simplifies sparse
8834f39
rtimms added a commit that referenced this issue Oct 18, 2019
@rtimms
#665 move jac to discretise
c6d5717
rtimms added a commit that referenced this issue Oct 18, 2019
@rtimms
#665 change default bahviour of jac
fbb18a4
rtimms added a commit that referenced this issue Oct 18, 2019
@rtimms
#665 fix update params
d9b3cf0
rtimms added a commit that referenced this issue Oct 18, 2019
@rtimms
#665 compute jac of simplified model before solve
6837960
@rtimms rtimms mentioned this issue Oct 18, 2019
Merged
8 tasks
rtimms added a commit that referenced this issue Oct 21, 2019
@rtimms
#665 tino comments
593370d
rtimms added a commit that referenced this issue Oct 21, 2019
@rtimms
#665 merge master
719bf55
rtimms added a commit that referenced this issue Oct 21, 2019
@rtimms
#665 jac of independent var
2559aef
rtimms added a commit that referenced this issue Oct 21, 2019
@rtimms
#665 add tests
e4bfe1a
rtimms added a commit that referenced this issue Oct 21, 2019
@rtimms
#665 debug jac of outer
9d1579c
rtimms added a commit that referenced this issue Oct 24, 2019
@rtimms
#665 codacy
93d9862
rtimms added a commit that referenced this issue Oct 24, 2019
@rtimms
#665 tino comments
d1b0b2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtimms rtimms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 665 jac class pybamm-team/PyBaMM
2 participants
@Scottmar93 @rtimms