Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make particle surface extrapolation 2nd order #704

Closed
Scottmar93 opened this issue Nov 5, 2019 · 0 comments · Fixed by #707
Closed

Make particle surface extrapolation 2nd order #704

Scottmar93 opened this issue Nov 5, 2019 · 0 comments · Fixed by #707
Assignees
@Scottmar93
Labels
feature

Comments

@Scottmar93
Copy link
Contributor

Summary
Make particle surface extrapolation 2nd order

Motivation
Increase accuracy of particle surface concentration to help match comsol better
@Scottmar93 Scottmar93 self-assigned this Nov 5, 2019
Scottmar93 added a commit that referenced this issue Nov 5, 2019
@Scottmar93
#704 updated boundary value to work on non-uniform grids
86bf852
Scottmar93 added a commit that referenced this issue Nov 5, 2019
@Scottmar93
#704 added tests for linear and quadratic and on nonuniform grids
6511376
Scottmar93 added a commit that referenced this issue Nov 5, 2019
@Scottmar93
#704 updated docs
8340f40
@Scottmar93 Scottmar93 mentioned this issue Nov 5, 2019
Merged
8 tasks
Scottmar93 added a commit that referenced this issue Nov 6, 2019
@Scottmar93
#704 added option to finite element boundary_value_or_flux
9bf4bc1
Scottmar93 added a commit that referenced this issue Nov 6, 2019
@Scottmar93
#704 added to spatial method aswell
22dc55c
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 removed the option in other functions
b6f3546
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 tested that the extrapolation is behaving properly
094ee49
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 added new extrapolation methods
cb1e5d0
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 converted to using options in finite volume
c435a1e
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 changed init of spatial methods
1c5c42b
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 fixed multiple unit tests as result of change of finite volume
8df9b22
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 passes unit tests
89d0d16
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 updated tests
fb794ff
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 added convergence tests for all types of extrapolation
8555a64
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 tidied up head of extrapolation file
a3eb545
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 changed defaults to be linear
b8d4335
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 finite volumes tests all pass
a8852fa
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 fixed finite volume integration tests
569aeb5
Scottmar93 added a commit that referenced this issue Nov 7, 2019
@Scottmar93
#704 added a short script to demonstrate comparison between extrapola…
92aa22b 
…tion methods
Scottmar93 added a commit that referenced this issue Nov 8, 2019
@Scottmar93
#704 fixed errors in scripts and notebooks
0dde075
Scottmar93 added a commit that referenced this issue Nov 8, 2019
@Scottmar93
#704 changed to has_bc_of_form
a2df853
Scottmar93 added a commit that referenced this issue Nov 8, 2019
@Scottmar93
#704 updated as suggested by rob and tino
269dadb
Scottmar93 added a commit that referenced this issue Nov 11, 2019
@Scottmar93
#704 fixed issue in notebook
f267ded
Scottmar93 added a commit that referenced this issue Nov 11, 2019
@Scottmar93
#704 fixed spm notebook
4951e17
Scottmar93 added a commit that referenced this issue Nov 11, 2019
@Scottmar93
#704 fixed neg_pos test
d1ddbd3
Scottmar93 added a commit that referenced this issue Nov 11, 2019
@Scottmar93
#704 fixed doc in scikit?
8e2c72c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Scottmar93 Scottmar93

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 704 surface extrapolation pybamm-team/PyBaMM
1 participant
@Scottmar93