-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify some objects on creation #709
Comments
valentinsulzer
added a commit
that referenced
this issue
Jan 31, 2020
valentinsulzer
added a commit
that referenced
this issue
Jan 31, 2020
valentinsulzer
added a commit
that referenced
this issue
Jan 31, 2020
valentinsulzer
added a commit
that referenced
this issue
Feb 1, 2020
valentinsulzer
added a commit
that referenced
this issue
Feb 1, 2020
valentinsulzer
added a commit
that referenced
this issue
Feb 2, 2020
valentinsulzer
added a commit
that referenced
this issue
Feb 3, 2020
valentinsulzer
added a commit
that referenced
this issue
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One way to reduce the size of the tree and hence make simplify faster could be to have some simple rules for simplifying objects on creation. For example,
Scalar(5) * Scalar(3)
returnsScalar(15)
; similarly forScalar * Array
andArray @ Array
.Since we are now planning on having specific
InputParameter
objects, this would not cause any problems for parameter estimation. We just lose functionality of being able to update parameter values in an already-created model - so you have to specify up front which parameters you will want to update. This is probably something to do after implementing some kind of input parameter node though, just to be safe.Thoughts?
The text was updated successfully, but these errors were encountered: