Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong temperature being used to calculate initial conditions #736

Closed
valentinsulzer opened this issue Nov 19, 2019 · 0 comments · Fixed by #737
Closed

Wrong temperature being used to calculate initial conditions #736

valentinsulzer opened this issue Nov 19, 2019 · 0 comments · Fixed by #737
Assignees
@valentinsulzer
Labels
bug Something isn't working

Comments

@valentinsulzer
Copy link
Member

Using T_ref instead of T_init. Leads to failing initial condition calculation in some cases.
@valentinsulzer valentinsulzer self-assigned this Nov 19, 2019
@valentinsulzer valentinsulzer added the bug Something isn't working label Nov 19, 2019
valentinsulzer added a commit that referenced this issue Nov 19, 2019
@valentinsulzer
#736 change T_ref to T_init

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
6dc4cc6
@valentinsulzer valentinsulzer mentioned this issue Nov 19, 2019
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Nov 19, 2019
@valentinsulzer
#736 changelog
6d949b0
valentinsulzer added a commit that referenced this issue Nov 19, 2019
@valentinsulzer
#736 undo debugging change
aaa9470
valentinsulzer added a commit that referenced this issue Nov 19, 2019
@valentinsulzer
Merge pull request #737 from pybamm-team/issue-736-ics
68539d3 
#736 change T_ref to T_init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#736 change T_ref to T_init pybamm-team/PyBaMM
1 participant
@valentinsulzer