Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neumann BCs in FV #741

Closed
rtimms opened this issue Nov 22, 2019 · 0 comments · Fixed by #748
Closed

Neumann BCs in FV #741

rtimms opened this issue Nov 22, 2019 · 0 comments · Fixed by #748
Assignees
@rtimms

Comments

@rtimms
Copy link
Contributor

rtimms commented Nov 22, 2019

At the moment we are adding ghost nodes for Neumann conditions in Finite Volumes rather than using the actual value
@rtimms rtimms self-assigned this Nov 25, 2019
rtimms added a commit that referenced this issue Nov 25, 2019
@rtimms
#741 remove ghost nodes from neumann
5bc9c7e
rtimms added a commit that referenced this issue Nov 25, 2019
@rtimms
#741 start adding neumann values
2a479b1
rtimms added a commit that referenced this issue Nov 25, 2019
@rtimms
#741 check for bc type
72cba18
rtimms added a commit that referenced this issue Nov 25, 2019
@rtimms
#741 fix shapes
5345c94
rtimms added a commit that referenced this issue Nov 25, 2019
@rtimms
#741 fix finite volume tests
3413dc4
@rtimms rtimms mentioned this issue Nov 25, 2019
Merged
8 tasks
rtimms added a commit that referenced this issue Nov 26, 2019
@rtimms
#741 coverage
181514e
rtimms added a commit that referenced this issue Nov 27, 2019
@rtimms
#741 move comment
2da72e8
rtimms added a commit that referenced this issue Nov 27, 2019
@rtimms
#741 add comment
45da69d
@rtimms rtimms mentioned this issue Nov 27, 2019
Closed
rtimms added a commit that referenced this issue Dec 13, 2019
@rtimms
#741 replace loop with matmul
18644d8
rtimms added a commit that referenced this issue Dec 13, 2019
@rtimms
#741 fix domain of bc vector
7479db8
rtimms added a commit that referenced this issue Dec 13, 2019
@rtimms
#741 fix shape in sec pts
bbe676d
rtimms added a commit that referenced this issue Dec 13, 2019
@rtimms
#741 remove ipdb
568f20d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtimms rtimms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 741 neumann bc pybamm-team/PyBaMM
1 participant
@rtimms