Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input symbol #743

Closed
valentinsulzer opened this issue Nov 22, 2019 · 0 comments · Fixed by #752
Closed

Input symbol #743

valentinsulzer opened this issue Nov 22, 2019 · 0 comments · Fixed by #752
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

Make a symbol pybamm.Input to allow passing parameters for (eventually) parameter estimation, etc.
This is similar to external variables, but slightly different because the inputs don't get discretised.
Covers similar functionality to param.update_model() but should be more efficient and user-friendly.
A potential workflow is

model = pybamm.lithium_ion.DFN()
param = model.default_parameter_values
param["Some parameter to vary quickly"] = pybamm.Input("Some parameter to vary quickly")
...
solver.solve(model, t_eval, inputs={"Some parameter to vary quickly": 4})
@valentinsulzer valentinsulzer self-assigned this Nov 26, 2019
valentinsulzer added a commit that referenced this issue Dec 1, 2019
@valentinsulzer
#743 flake8
cfcc83e
valentinsulzer added a commit that referenced this issue Dec 1, 2019
@valentinsulzer
#743 merge master
79ef0b7
valentinsulzer added a commit that referenced this issue Dec 1, 2019
@valentinsulzer
#743 fix jacobian for input parameter
6b675f6
valentinsulzer added a commit that referenced this issue Dec 1, 2019
@valentinsulzer
#743 get scipy solver working with python
c80f38a
valentinsulzer added a commit that referenced this issue Dec 1, 2019
@valentinsulzer
#743 fix scikits solvers without inputs
544c0dd
valentinsulzer added a commit that referenced this issue Dec 1, 2019
@valentinsulzer
#743 scikits solvers working with inputs
64ffdd8
valentinsulzer added a commit that referenced this issue Dec 1, 2019
@valentinsulzer
#743 casadi solver works without events
166681e
valentinsulzer added a commit that referenced this issue Dec 1, 2019
@valentinsulzer
#743 fixing tests
98a76f6
valentinsulzer added a commit that referenced this issue Dec 1, 2019
@valentinsulzer
#743 add inputs to processed variable
40db53b
@valentinsulzer valentinsulzer mentioned this issue Dec 1, 2019
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Dec 4, 2019
@valentinsulzer
#743 fix tests [ci skip]
1c53cfc
valentinsulzer added a commit that referenced this issue Dec 4, 2019
@valentinsulzer
#743 remove notebooks
68d960b
valentinsulzer added a commit that referenced this issue Dec 4, 2019
@valentinsulzer
#743 bug fixes and coverage
22c8ae8
valentinsulzer added a commit that referenced this issue Dec 4, 2019
@valentinsulzer
#743 more bugs and coverage
15e7dc3
valentinsulzer added a commit that referenced this issue Dec 5, 2019
@valentinsulzer
#743 codacy
136244c
valentinsulzer added a commit that referenced this issue Dec 5, 2019
@valentinsulzer
#743 changelog
662f40d
valentinsulzer added a commit that referenced this issue Dec 5, 2019
@valentinsulzer
#743 add input to simulation step
f9c8a26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 743 input node pybamm-team/PyBaMM
1 participant
@valentinsulzer