Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying solver interface #784

Closed
valentinsulzer opened this issue Jan 13, 2020 · 2 comments · Fixed by #800
Closed

Simplifying solver interface #784

valentinsulzer opened this issue Jan 13, 2020 · 2 comments · Fixed by #800
Assignees

Comments

@valentinsulzer
Copy link
Member

It should be possible to merge

  • base_solver, ode_solver and dae_solver into a single base class
  • scikits_ode_solver and scikits_dae_solver into a single class

Do you think this would simplify the interface @rtimms ?

@rtimms
Copy link
Contributor

rtimms commented Jan 14, 2020

yeah I think that would be good. could we also remove compute_solution and call integrate directly from solve and step? compute_solution saves rewriting the little integrate, get termination reason block of code in both step and solve, but it wouldn't be a massive bit of repetition and would probably be easier to follow for new users. (I think I introduced compute_solution, but I don't like it now haha)

I think the only solver with a drastically different interface is casadi, and we already overwrite some methods there anyway.

@valentinsulzer
Copy link
Member Author

Ok, that sounds good - no worries, compute_solution seemed like a good idea at the time haha

@valentinsulzer valentinsulzer self-assigned this Jan 15, 2020
valentinsulzer added a commit that referenced this issue Jan 20, 2020
valentinsulzer added a commit that referenced this issue Jan 20, 2020
valentinsulzer added a commit that referenced this issue Jan 20, 2020
valentinsulzer added a commit that referenced this issue Jan 20, 2020

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
valentinsulzer added a commit that referenced this issue Jan 20, 2020
valentinsulzer added a commit that referenced this issue Jan 20, 2020
valentinsulzer added a commit that referenced this issue Jan 21, 2020
valentinsulzer added a commit that referenced this issue Jan 24, 2020
valentinsulzer added a commit that referenced this issue Jan 26, 2020
valentinsulzer added a commit that referenced this issue Jan 26, 2020
valentinsulzer added a commit that referenced this issue Jan 26, 2020
valentinsulzer added a commit that referenced this issue Jan 27, 2020
valentinsulzer added a commit that referenced this issue Jan 28, 2020
valentinsulzer added a commit that referenced this issue Jan 30, 2020
valentinsulzer added a commit that referenced this issue Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants