Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search parameters and variables #869

Closed
rtimms opened this issue Mar 4, 2020 · 0 comments · Fixed by #875
Closed

Search parameters and variables #869

rtimms opened this issue Mar 4, 2020 · 0 comments · Fixed by #875
Assignees
@rtimms

Comments

@rtimms
Copy link
Contributor

rtimms commented Mar 4, 2020

As @TomTranter suggests there are a lot of variables and parameters, and we should add a search function. This could be done in pybamm.FuzzyDict. We could search for keys containing the word a user searches for, and then provide best matches if there are no results.
@rtimms rtimms self-assigned this Mar 9, 2020
rtimms added a commit that referenced this issue Mar 9, 2020
@rtimms
#869 add search
357680c
rtimms added a commit that referenced this issue Mar 9, 2020
@rtimms
#869 add test
4e26ee2
rtimms added a commit that referenced this issue Mar 9, 2020
@rtimms
#869 update docstrings
094c10e
@rtimms rtimms mentioned this issue Mar 9, 2020
Merged
8 tasks
rtimms added a commit that referenced this issue Mar 10, 2020
@rtimms
#869 changelog
4c1ed31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtimms rtimms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 869 search pybamm-team/PyBaMM
1 participant
@rtimms