Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make t and x dimensional in interpolation #920

Closed
valentinsulzer opened this issue Mar 26, 2020 · 0 comments · Fixed by #1028
Closed

Make t and x dimensional in interpolation #920

valentinsulzer opened this issue Mar 26, 2020 · 0 comments · Fixed by #1028
Assignees
@rtimms

Comments

@valentinsulzer
Copy link
Member

For consistency of the user-facing interface, values supplied to a parameter when interpolating should always be dimensional.
@rtimms rtimms mentioned this issue May 20, 2020
Closed
@rtimms rtimms self-assigned this May 27, 2020
rtimms added a commit that referenced this issue May 27, 2020
@rtimms
#920 make calls to processed var dimensional

Verified

This commit was signed with the committer’s verified signature.
lionkor Lion
GPG key ID: 4322FF2B4C71259B
Verified
Learn about vigilant mode
aafaa55
rtimms added a commit that referenced this issue May 28, 2020
@rtimms
#920 fix examples

Verified

This commit was signed with the committer’s verified signature.
lionkor Lion
GPG key ID: 4322FF2B4C71259B
Verified
Learn about vigilant mode
7561597
rtimms added a commit that referenced this issue May 28, 2020
@rtimms
#920 debugging integration tests
347654c
rtimms added a commit that referenced this issue May 28, 2020
@rtimms
#920 fix most integration tests
98c06cb
rtimms added a commit that referenced this issue May 28, 2020
@rtimms
#920 fix convection tests
ad49ca7
@rtimms rtimms mentioned this issue May 28, 2020
Merged
8 tasks
rtimms added a commit that referenced this issue May 29, 2020
@rtimms
#920 tino comments
af679e2
rtimms added a commit that referenced this issue May 29, 2020
@rtimms
#920 fix my typo in solver tols
b2b03dc
rtimms added a commit that referenced this issue May 29, 2020
@rtimms
#920 fix timescale
9169fcc
rtimms added a commit that referenced this issue May 29, 2020
@rtimms
#920 timescale with inputs
b494776
rtimms added a commit that referenced this issue May 29, 2020
@rtimms
#920 raise error if timescale depends on inputs
7572a09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtimms rtimms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 920 dimensional interp pybamm-team/PyBaMM
2 participants
@valentinsulzer @rtimms