Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recalculate initial conditions during parameter sweeps #943

Closed
valentinsulzer opened this issue Apr 5, 2020 · 0 comments · Fixed by #951
Closed

Recalculate initial conditions during parameter sweeps #943

valentinsulzer opened this issue Apr 5, 2020 · 0 comments · Fixed by #951
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

During parameter sweeps, initial conditions only get calculated once (at the first solve), and then are fixed for all future solves. They should be recalculated each time if the algebraic equations or initial conditions change when an input changes.
@valentinsulzer valentinsulzer self-assigned this Apr 9, 2020
valentinsulzer added a commit that referenced this issue Apr 10, 2020
@valentinsulzer
#943 recalculate initial conditions
08bb097
valentinsulzer added a commit that referenced this issue Apr 10, 2020
@valentinsulzer
#943 bug fixed
4fb9151
valentinsulzer added a commit that referenced this issue Apr 10, 2020
@valentinsulzer
#943 changelog [ci skip]
d0386aa
@valentinsulzer valentinsulzer mentioned this issue Apr 13, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 943 initial conditions pybamm-team/PyBaMM
1 participant
@valentinsulzer