Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.3 release #1095

Merged
merged 277 commits into from
Jul 1, 2020
Merged

v0.2.3 release #1095

merged 277 commits into from
Jul 1, 2020

Conversation

valentinsulzer
Copy link
Member

Description

Merging develop into master for v0.2.3 release (right way round this time)

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #1095 into master will decrease coverage by 0.26%.
The diff coverage is 99.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1095      +/-   ##
==========================================
- Coverage   98.03%   97.76%   -0.27%     
==========================================
  Files         252      243       -9     
  Lines       15422    12667    -2755     
==========================================
- Hits        15119    12384    -2735     
+ Misses        303      283      -20     
Impacted Files Coverage Δ
pybamm/expression_tree/state_vector.py 100.00% <ø> (ø)
pybamm/solvers/idaklu_solver.py 88.99% <ø> (-1.59%) ⬇️
pybamm/expression_tree/binary_operators.py 94.95% <87.50%> (-0.55%) ⬇️
pybamm/discretisations/discretisation.py 99.77% <100.00%> (-0.08%) ⬇️
pybamm/expression_tree/array.py 100.00% <100.00%> (ø)
pybamm/expression_tree/broadcasts.py 100.00% <100.00%> (ø)
pybamm/expression_tree/concatenations.py 97.45% <100.00%> (ø)
pybamm/expression_tree/functions.py 100.00% <100.00%> (ø)
pybamm/expression_tree/independent_variable.py 100.00% <100.00%> (ø)
pybamm/expression_tree/input_parameter.py 100.00% <100.00%> (ø)
... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd26cc7...56c0383. Read the comment docs.

Only update entropic variables if reaction_name is empty
Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy if it passes the tests

Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valentinsulzer valentinsulzer merged commit 09a3c08 into master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants