-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename cathode and anode #1337
Rename cathode and anode #1337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should discuss in the meeting that this is not too much of a breaking change. But the changes themselves are all good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a suggestion for an extra error check
… provided (same for cathode)
@@ -151,6 +153,42 @@ def update_from_chemistry(self, chemistry): | |||
if "sei" in chemistry: | |||
component_groups += ["sei"] | |||
|
|||
if "anode" in chemistry.keys(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tinosulzer @tlestang here are the warnings/errors you suggested, in case you want to take a look. Otherwise, let me know and I will merge the branch.
Description
Notation has been homogenised to use positive and negative electrode (instead of cathode and anode). This applies to the options in the cracking model and lost of active material and the parameter folders.
Fixes #1333
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: