-
-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'operating mode' to the doc string of BaseBatteryModel class #1404
Added 'operating mode' to the doc string of BaseBatteryModel class #1404
Conversation
Warning, treated as error:
/home/runner/work/PyBaMM/PyBaMM/pybamm/models/full_battery_models/base_battery_model.py:docstring of pybamm.models.full_battery_models.base_battery_model.BaseBatteryModel:98:Unexpected indentation. Is this fail/error somehow related to the '\' I removed? |
I guess it might help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Saransh-cpp , looks good once the tests pass
Thanks! I will add the backslashes that were removed. |
I've just seen your coment about the huge spaces in the output - good catch. Would be good to figure out a way that doesn't have that problem. If it looks fine in the docs without the \ then maybe we can edit the doctest |
Either I could have formatted the doc string to look good when it is displayed on the terminal or in the code base, I added all the '\'s to make it look good in the codebase. If you want then I can add an empty line after every backslash that is creating a problem (this will make the docstring look a bit weird in the codebase with extra empty lines), I tested this on my side and it outputs the docstring well formatted. Edit: Yes it looks good without the backslashes, please let me know if I should make any changes. Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #1404 +/- ##
========================================
Coverage 98.22% 98.22%
========================================
Files 278 278
Lines 15806 15806
========================================
Hits 15526 15526
Misses 280 280
Continue to review full report at Codecov.
|
Let's keep the backslash, it looks fine here: https://pybamm.readthedocs.io/en/latest/source/models/base_models/base_battery_model.html |
Description
Please let me know if you want any changes or additions in the PR. Thanks!
Fixes #1388
Type of change
Doc string addition
Key checklist:
Further checks: