-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add BatchStudy class #1455
add BatchStudy class #1455
Conversation
What does Could you please check it? You can run this code here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @priyanshuone6 , on the right track. See comments, and needs a unit test
Thanks @tinosulzer |
Codecov Report
@@ Coverage Diff @@
## develop #1455 +/- ##
========================================
Coverage 98.34% 98.34%
========================================
Files 281 282 +1
Lines 16516 16563 +47
========================================
+ Hits 16242 16289 +47
Misses 274 274
Continue to review full report at Codecov.
|
622e278
to
7459943
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @priyanshuone6 , can you just add the other options for the Simulation? parameter_values, var_pts, etc
Also add the options for solve
6529de7
to
7edf780
Compare
Description
Add class to compare different models and conditions
Fixes #906
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: