-
-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a function to plot "summary variables" #1678
Added a function to plot "summary variables" #1678
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1678 +/- ##
========================================
Coverage 99.27% 99.27%
========================================
Files 342 343 +1
Lines 18720 18742 +22
========================================
+ Hits 18585 18607 +22
Misses 135 135
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks Saransh!
a31517e
to
832af69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
Parameters | ||
---------- | ||
solutions : (iter of) :class:`pybamm.Solution` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be made to work if only a single solution is provided not in a list, e.g.
if isinstance(solutions, pybamm.Solution):
solutions = [solutions]
Description
Added a function to plot and compare summary variables.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: