-
-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use unique artifact names #4015
Use unique artifact names #4015
Conversation
Triggered a workflow run on my fork to ensure everything works: https://github.com/agriyakhetarpal/PyBaMM/actions/runs/8715941402 (edit: nevermind, the PyPI publishing job won't run on forks). I think it should be safe to merge, though. The Windows failures from Chocolatey are unrelated. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4015 +/- ##
========================================
Coverage 99.58% 99.58%
========================================
Files 257 257
Lines 21249 21249
========================================
Hits 21161 21161
Misses 88 88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @agriyakhetarpal! Looks good to me!
* pybamm-team#3489 Use unique artifact names for all jobs * Limit benchmarks results to PyBaMM repo
Description
Addresses one out of two parts of issue #3489 – resolves artifacts names and how they are downloaded to fix the rule
GH104 Use unique names for upload-artifact
. They are now all downloaded in one folder for the benchmarks and the wheel builder workflows.Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).