Code

Issue 546 models#564

Code

Merged

valentinsulzer merged 33 commits intomasterpybamm-team/PyBaMM:masterfrom issue-546-modelspybamm-team/PyBaMM:issue-546-modelsCopy head branch name to clipboardAug 2, 2019

Commits

Commits on Jul 28, 2019

• #546 separate current collector model and dimensionality in options

  valentinsulzer

  committed
  85dc152

  Copy full SHA for 85dc152

• #546 change negative electrode boundary condition

  valentinsulzer

  committed
  2a69647

  Copy full SHA for 2a69647

• #546 get new form mostly working

  valentinsulzer

  committed
  506688c

  Copy full SHA for 506688c

• #546 reformat to remove one algebraic equation

  valentinsulzer

  committed
  96cf538

  Copy full SHA for 96cf538

• #546 debugging

  valentinsulzer

  committed
  644fa79

  Copy full SHA for 644fa79

• #546 1+1 LOQS working well, others not

  valentinsulzer

  committed
  ca0e7d5

  Copy full SHA for ca0e7d5

• #546 major shit hit the fan moment

  valentinsulzer

  committed
  1ad233b

  Copy full SHA for 1ad233b

• merge changes from 2d disc branch

  valentinsulzer

  committed
  50a82b5

  Copy full SHA for 50a82b5

• Merge branch 'issue-546-2plus1-lead-acid' into issue-546-models

  valentinsulzer

  committed
  c189956

  Copy full SHA for c189956

• #546 reaction diffusion working in 2D

  valentinsulzer

  committed
  2e56441

  Copy full SHA for 2e56441

• #546 some progress with the 2D discretisation

  valentinsulzer

  committed
  1316a92

  Copy full SHA for 1316a92

• #546 1+1D composite working, without jacobian

  valentinsulzer

  committed
  a304257

  Copy full SHA for a304257

Commits on Jul 30, 2019

• #546 compsite potential pair model

  valentinsulzer

  committed
  57ccc0d

  Copy full SHA for 57ccc0d

• #546 merge #554

  valentinsulzer

  committed
  535282c

  Copy full SHA for 535282c

• #546 1+1D LOQS and Composite working

  valentinsulzer

  committed
  8aaf038

  Copy full SHA for 8aaf038

• #546 1+1D Newman-Tiedemann working also

  valentinsulzer

  committed
  accae6e

  Copy full SHA for accae6e

Commits on Jul 31, 2019

• #546 add jacobian to the initial condition calculator

  valentinsulzer

  committed
  9a07f91

  Copy full SHA for 9a07f91

Commits on Aug 1, 2019

• Merge branch 'issue-554-2dbug' into issue-546-models

  valentinsulzer

  committed
  8a9ac1a

  Copy full SHA for 8a9ac1a

• #546 add tests for jacobian

  valentinsulzer

  committed
  a7ed4bd

  Copy full SHA for a7ed4bd

• #546 fix unit tests

  valentinsulzer

  committed
  f96191d

  Copy full SHA for f96191d

• #546 some codacy

  valentinsulzer

  committed
  5538eb4

  Copy full SHA for 5538eb4

• #546 merge #554

  valentinsulzer

  committed
  9d7ed4a

  Copy full SHA for 9d7ed4a

• #546 reformat interaction between current collector and through-cell

  valentinsulzer

  committed
  3b7faae

  Copy full SHA for 3b7faae

• #546 fix unit tests

  valentinsulzer

  committed
  82482a7

  Copy full SHA for 82482a7

• #546 add quite conductive model

  valentinsulzer

  committed
  9a80aba

  Copy full SHA for 9a80aba

• #546 working on quite conductive model

  valentinsulzer

  committed
  f17ae8a

  Copy full SHA for f17ae8a

• #546 quite conductive model runs but with weird results

  valentinsulzer

  committed
  fcdda59

  Copy full SHA for fcdda59

• #546 improve composite model

  valentinsulzer

  committed
  1fef9d1

  Copy full SHA for 1fef9d1

• #546 fix unit tests

  valentinsulzer

  committed
  4e49c2f

  Copy full SHA for 4e49c2f

• #546 debugging

  valentinsulzer

  committed
  49e3d0d

  Copy full SHA for 49e3d0d

Commits on Aug 2, 2019

• #546 coverage

  valentinsulzer

  committed
  cf47f80

  Copy full SHA for cf47f80

• #546 Rob comments

  valentinsulzer

  committed
  56ccedf

  Copy full SHA for 56ccedf

• #546 fix tests

  valentinsulzer

  committed
  fbbf1ed

  Copy full SHA for fbbf1ed