Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #677 - observer quick plotting #678

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

BradyPlanden
Copy link
Member

Description

feat: updates observer.evaluate to align w/ BaseProblem.evaluate

Issue reference

Fixes #677

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

Sorry, something went wrong.

@BradyPlanden BradyPlanden linked an issue Feb 20, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.23%. Comparing base (828a8e3) to head (2cf4cfd).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #678      +/-   ##
===========================================
- Coverage    99.27%   99.23%   -0.05%     
===========================================
  Files           64       66       +2     
  Lines         4813     4817       +4     
===========================================
+ Hits          4778     4780       +2     
- Misses          35       37       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden added the show This PR will be merged without review label Feb 20, 2025
@BradyPlanden BradyPlanden merged commit 980ea78 into develop Feb 20, 2025
31 checks passed
@BradyPlanden BradyPlanden deleted the 677-bug-quick-plot-broken-for-observer-class branch February 20, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
show This PR will be merged without review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: quick plot broken for observer class
1 participant