Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affecting charges are listed as the firing weapon system #335

Closed
blitzmann opened this issue Jul 18, 2015 · 1 comment
Closed

Affecting charges are listed as the firing weapon system #335

blitzmann opened this issue Jul 18, 2015 · 1 comment

Comments

@blitzmann
Copy link
Collaborator

Showing affected by for 125mm Gat auto with Barrage S shows that the charges modifiers are listed as the gun

@blitzmann
Copy link
Collaborator Author

The reason it happened this way is because charges are not separate from modules. Instead, a Module class as both the module item and the charge item set, and when the calculations are run the charge gets lumped into it.

When it's represented, however, it looks like the module is modifying itself, due to an oversight in the GUI. We could have made a Charge object, but that's more involved and unneeded. Instead, we check the list of afflictors and see if they match the item we're looking at. If so, we use the charge as the item, instead of the modules item. This required a little bit of tweaking in how the dictionaries are put together on the GUI side, but worked out well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant