Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Change affecting skill" context menu, resolves #101 #110

Merged
merged 5 commits into from
Jun 1, 2014

Conversation

blitzmann
Copy link
Collaborator

See #101 for progress and discussion of these changes

  • Includes two changes to EOS
    • Modifiers are added to modifier list regardless if they modify any attributes at the time. A new used parameter is introduced to replace the functionality to marking a modifier as modifying something.
    • Characters load all skills now, and all skills are saved in the database (previous mechanism was that only skills that were modified were added to database as needed). This is done in a way which is backwards compatible with current pyfa installations, and any addition of new skills to the game will also be covered by this change
  • Changes the item view to only show modifiers that are used (see EOS change)
  • Creates context menu that allows us to change a skill that affects a module / ship.
  • Adds custom icons to represent skill level

Screenshot:
skillsaffectors

blitzmann added 5 commits May 25, 2014 14:48
…ed in modifiedAttributeDict.

The previous method was to only add those that change a value. This adds things can can affect it, and then pass a new `used` flag to the dict to show if it's used or not.
@blitzmann blitzmann changed the title Add "Change affecting skill" context menu Add "Change affecting skill" context menu, resolves #101 May 29, 2014
@blitzmann
Copy link
Collaborator Author

I also made another set of icons based on some that I found in the EVE images toolkit. I like them, bt couldn't really decide if the 'signal' bars were better. Pic:
alticons

If this request is accepted, I can include both sets of icons in separate directories in icons. I don't think it's worth it to make GUI support to switch between them - the user can just overwrite from the directory to the main icon folder if they like them better.

@DarkFenX
Copy link
Member

DarkFenX commented Jun 1, 2014

I like 1st set of icons more.

DarkFenX added a commit that referenced this pull request Jun 1, 2014
Add "Change affecting skill" context menu, resolves #101
@DarkFenX DarkFenX merged commit 0769258 into pyfa-org:master Jun 1, 2014
@blitzmann blitzmann deleted the issue-101 branch June 3, 2014 04:15
w9jds pushed a commit to w9jds/Pyfa that referenced this pull request Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants