Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wxWidget crash caused by GDI object limit #2629

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

cryonox
Copy link
Contributor

@cryonox cryonox commented Aug 15, 2024

This closes

#2121
#2261
#2225

@cryonox cryonox changed the title Fix wxWidget crash caused by GDI id limit Fix wxWidget crash caused by GDI object limit Aug 15, 2024
@DarkFenX
Copy link
Member

Sorry for missing the pull request. Was busy with AT and kids. Will look into it later this week

@DarkFenX
Copy link
Member

What is gui/utils/gdi.py for? Was it used for debugging?

@cryonox
Copy link
Contributor Author

cryonox commented Nov 27, 2024

Ya it was used to check "memory leak" from gc and to know the current gdi object count so that I know if it's about to crash or not. I thought it might be useful in case this kind of thing happen again since I am pretty sure shipbrowser is not the only place this is happening. it's just the worst case of it.

@DarkFenX DarkFenX closed this Nov 27, 2024
@DarkFenX
Copy link
Member

Thx, i wish i had enough experience to debug similar crashes on linux/mac

@cryonox
Copy link
Contributor Author

cryonox commented Nov 30, 2024

Did you forgot to merge? @DarkFenX

@DarkFenX
Copy link
Member

DarkFenX commented Dec 5, 2024

Oh wtf

@DarkFenX DarkFenX reopened this Dec 5, 2024
@DarkFenX DarkFenX merged commit 0f4b082 into pyfa-org:master Dec 5, 2024
1 check was pending
@DarkFenX
Copy link
Member

DarkFenX commented Dec 5, 2024

Sorry about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants