Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python version gate in _make_strs. #333

Merged
merged 2 commits into from
Mar 9, 2025
Merged

Remove Python version gate in _make_strs. #333

merged 2 commits into from
Mar 9, 2025

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Mar 8, 2025

No description provided.

@jaraco jaraco mentioned this pull request Mar 8, 2025
@jaraco jaraco changed the title Disable functionality in _make_strs. Remove Python version gate in _make_strs. Mar 8, 2025
@jaraco
Copy link
Member Author

jaraco commented Mar 8, 2025

I tried removing the behavior altogether, but it's still needed on Windows in Python 3.13.

The reliance on str appears to be in msvc, so maybe it's possible to perform the conversion there instead.

@jaraco jaraco merged commit 82780b7 into main Mar 9, 2025
40 of 44 checks passed
@jaraco jaraco deleted the debt/make-strs branch March 9, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant