fix PEP 518 configuration #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit-pierre
force-pushed
the
fix_pyproject.toml
branch
from
7686079 to
601f82e
Compare
Add `build-system.requires` key to `pyproject.toml`: - this is necessary with pip 10.0.1, as otherwise the defaults will be to require both `setuptools` and `wheel` (and we only need the later) - a `pyproject.toml` with no `build-system.requires` key will be invalid and rejected by a future version of pip (see pypa/pip#5416 (comment))
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add
build-system.requireskey topyproject.toml:setuptoolsandwheel(and we only need the later)pyproject.tomlwith nobuild-system.requireskey will be invalid and rejected by a future version of pip (see PEP 518: Behavior when pyproject.toml doesn't have build-system.requires pip#5416 (comment))Pull Request Checklist