Add timeout to test_build_meta
#3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in pypa#3087, `test_build_meta` seems to be flaky specially for the combination of Windows + PyPy. This is a proposed workaround for such scenarios.
jaraco
approved these changes
Feb 12, 2022
This is an attempt to avoid tasks lingering for hours as observed in the CI for the combination Windows+PyPy.
|
There are still some hickups (in other tests maybe), but I think this commit might help. |
abravalheri
force-pushed
the
flaky-test-build-meta
branch
from
f904e59 to
210a141
Compare
According to the Python docs, shutting down the process pool does not terminate the tasks that are already running, so it is necessary to manually kill the individual processes in the pool.
abravalheri
force-pushed
the
flaky-test-build-meta
branch
from
210a141 to
3c17f76
Compare
|
FYI, auto-merge doesn't work, but it's still nice to know it's ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3087,
test_build_metaseems to be flaky specially for the combination of Windows + PyPy.This is a proposed workaround for such scenarios.
Summary of changes
Closes
Pull Request Checklist
changelog.d/.(See documentation for details)