fix for #104 large file support #105
Conversation
|
As I mentioned on #104 this does not do what you think it does. |
|
yeah it see it just delays the issue |
| data_to_send = [] | ||
| for key, value in data.items(): | ||
| if isinstance(value, (list, tuple)): | ||
| for item in value: |
There was a problem hiding this comment.
Why does this need to be added?
There was a problem hiding this comment.
otherwise classifiers (and any other list/tuple) was being picked up by this
There was a problem hiding this comment.
Okay. One other question, why is data_to_send a list instead of a dictionary?
There was a problem hiding this comment.
because currently the same key is sent as many times as it has values, so just to keep the same behavior
|
Travis isn't going to run the tests because this branch doesn't cleanly merge into master. Are you comfortable rebasing this branch on top of master? |
|
@a-tal I didn't mean that you should squash this into one commit. You need to rebase your commit onto master. |
No description provided.