Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow type error without code #1456

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Disallow type error without code #1456

merged 1 commit into from
Oct 31, 2024

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Oct 31, 2024

I strengthen the mypy and ruff config a bit to disallow type: ignore with no code, found one case when the ignore can be removed

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (6a38287) to head (10e3b6a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1456   +/-   ##
=======================================
  Coverage   96.50%   96.50%           
=======================================
  Files          20       20           
  Lines        1830     1830           
=======================================
  Hits         1766     1766           
  Misses         64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snowman2 snowman2 merged commit 25fc1fd into pyproj4:main Oct 31, 2024
18 checks passed
@snowman2
Copy link
Member

Thanks @tqa236 👍

@tqa236 tqa236 deleted the lint-error branch October 31, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants