-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClassBuilder: eval only once #1407
Conversation
8e5debe
to
d473ae9
Compare
33e139d
to
2960493
Compare
CodSpeed Performance ReportMerging #1407 will improve performances by 52.27%Comparing Summary
Benchmarks breakdown
|
c9c5635
to
993e6f8
Compare
993e6f8
to
0dc578e
Compare
I added type hints to some internal functions. This was to make dev easier for me, not to type-check formally. |
for more information, see https://pre-commit.ci
This reverts commit 4e0af4b.
This reverts commit 532faed.
do you think it would be a lot of work to make the code base pass in lenient mode? I.e. if there's hints, they must not contradict otherwise YOLO? |
Not sure, but it might be worth it. Should be a different PR of course. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
News fragment please, then I think this is good to go.
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vroom, fucking, vroom
No description provided.