Added PDF read for macOS #1969
Closed
Added PDF read for macOS #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| raise SyntaxError("PDF file could not be converted") | ||
|
|
||
| im = Image.open(filepath) | ||
| im.load() |
There was a problem hiding this comment.
Ah, ok. Because we are deleting source file.
|
In my opinion, this is not PDF image files reader, Instead this is PDF converter. Of course, it can be very useful, but I don't think that Pillow is the best place for this code. In my opinion it is better to create separate package. |
|
I'd probably prefer a more generic approach to reading PDFs (i.e. cross plat, not macOS only) |
|
@aclark4life I'm for adding PDF reading, but not with such approach. |
|
Sure. Feel free to close. The thinking was just that perhaps adding functionality for one platform was better than no functionality. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS X has a command line tool called 'sips' installed by default. It is able to convert the first page of a PDF to an image. So this PR adds PDF read functionality for OS X by converting a PDF into a temporary file and then loading the file as a PngImageFile. Not quite sure about this approach, so I thought I'd put it up here for feedback before adding anything like documentation or tests.
This could be considered a partial implementation of #471